Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [IOCOM-1822] fims history export saga tests #6677

Conversation

forrest57
Copy link
Contributor

Short description

addition of said tests

List of changes proposed in this pull request

  • required saga tests

How to test

automated tests should pass

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Feb 3, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.00%. Comparing base (313e6ab) to head (b7d853e).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (313e6ab) and HEAD (b7d853e). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (313e6ab) HEAD (b7d853e)
10 6
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6677      +/-   ##
==========================================
- Coverage   49.99%   40.00%   -9.99%     
==========================================
  Files        1544     1535       -9     
  Lines       32163    32034     -129     
  Branches     7241     7246       +5     
==========================================
- Hits        16079    12816    -3263     
- Misses      16045    19169    +3124     
- Partials       39       49      +10     

see 284 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 313e6ab...b7d853e. Read the comment docs.

Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forrest57 forrest57 enabled auto-merge February 3, 2025 16:32
@forrest57 forrest57 added this pull request to the merge queue Feb 3, 2025
Merged via the queue into master with commit 211d849 Feb 3, 2025
22 checks passed
@forrest57 forrest57 deleted the IOCOM-1822-app-test-automatici-saga-handle-export-fims-history branch February 3, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants